Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Update VISA examples to use the new session management API #446

Merged
merged 7 commits into from
Oct 13, 2023
Merged

examples: Update VISA examples to use the new session management API #446

merged 7 commits into from
Oct 13, 2023

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Oct 13, 2023 •
edited
Loading

What does this Pull Request accomplish?

Update nivisa_dmm_measurement and output_voltage_measurement to use the new session management API.

Add more supported instrument IDs to _visa_dmm.py.

Update .env.sample and .env.simulation.

Why should this Pull Request be merged?

Resolves AB#2527580

What testing has been done?

Manually tested both examples with simulation and a HP 34401A connected over GPIB.
Also tested the first example with an NI Instrument Simulator v2.0 connected over serial.

@bkeryan
examples: Add more instrument IDs to _visa_dmm.py
ec0664c 
RuntimeError: The ID query failed. This may mean that you selected the wrong instrument, your instrument did not respond, or you are using a model that is not officially supported by this driver. Instrument ID: National Instruments,Instrument Simulator,0181CCEE,2.0.1.d1
@bkeryan
examples: Update nivisa_dmm_measurement to use the new session manage…
569c640 
…ment API
@bkeryan
examples: Update output_voltage_measurement to use the new session ma…
4908c94 
…nagement API
@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

Test Results

       30 files  ±0       30 suites  ±0   23m 19s ⏱️ - 2m 10s
     452 tests ±0     376 ✔️ ±0       76 💤 ±0  0 ❌ ±0 
13 530 runs  ±0  9 650 ✔️ ±0  3 880 💤 ±0  0 ❌ ±0 

Results for commit 731ff5e. ± Comparison against base commit 8393c2d.

♻️ This comment has been updated with latest results.

dixonjoel
dixonjoel approved these changes Oct 13, 2023
View reviewed changes
examples/output_voltage_measurement/measurement.py Outdated Show resolved Hide resolved
examples/output_voltage_measurement/_visa_dmm.py Outdated Show resolved Hide resolved
examples/nivisa_dmm_measurement/_visa_dmm.py Show resolved Hide resolved
@dixonjoel dixonjoel mentioned this pull request Oct 13, 2023
Merged
1 task
@bkeryan bkeryan mentioned this pull request Oct 13, 2023
Closed
@bkeryan bkeryan linked an issue Oct 13, 2023 that may be closed by this pull request
use_simulation_option cmd line option in examples has no effect #395
Closed
@bkeryan bkeryan merged commit 70b0600 into main Oct 13, 2023
20 checks passed
@bkeryan bkeryan deleted the users/bkeryan/update-visa-examples branch October 13, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel dixonjoel approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@pbirkhol-ni pbirkhol-ni Awaiting requested review from pbirkhol-ni

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_simulation_option cmd line option in examples has no effect
2 participants
@bkeryan @dixonjoel