examples: Update TestStand code modules for NIVISA-DMM, NI-Digital and Output voltage examples #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaseelan-james
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
|
@bkeryan, @dixonjoel Please consider reviewing the PR changes. I've added the "Retarget needed" tag, as the PR is targeting the #481 branch due to the |
bkeryan
approved these changes
Oct 26, 2023
Base automatically changed from
users/avinash/update_teststand_code_modules_part_one
to
main
October 26, 2023 16:48
ok, I merged #481 |
dixonjoel
changed the title
dixonjoel
approved these changes
Oct 26, 2023
vigkre
requested changes
Oct 26, 2023
jayaseelan-james
force-pushed
the
users/jay/update-ts-nivisa-output-meas
branch
from
0280d98
to
36203fb
Compare
vigkre
approved these changes
Oct 27, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates the nivisa-dmm, nidigital and output voltage example's TestStand code modules to use the new session management API.
Note: Updating the TestStand code modules to use the new session management API will suffice to make sure the simulation config is read from
.envfile.Why should this Pull Request be merged?
Uses the same session creation code as for measurements, with simulation via. .env file.
What testing has been done?
Manually tested with TestStand 2021 SP1.
Note: I've added the "Retarget needed" tag, as the PR is targeting the #481 branch due to the
create_dcpower_sessionsAPI update toinitialize_nidcpower_sessions. Will retarget once the #481 PR goes in.