Add timeout of 10s for reserve_all_registered_sessions() #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchris007
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
samchris007
changed the title
1 task
SowmyaRavee
approved these changes
Apr 12, 2024
dixonjoel
approved these changes
Apr 12, 2024
jasonmreding
approved these changes
Apr 12, 2024
bkeryan
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
@dixonjoel Make sure to document the changed default value in the release notes
jayaseelan-james
deleted the
users/sam/add-timeout-ReserveAllRegisteredSessions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds timeouts while destroying sessions for the measurements in TestStand
Why should this Pull Request be merged?
Resolves User Story 2676827: Add timeout as 10s when destroying sessions in the TestStand sequences
What testing has been done?
Manually verified by running and aborting the measurement steps in the NI-FGEN and NI-DAQmx examples