Pull in .proto files from ni-apis repo as a submodule #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixonjoel
requested review from
csjall,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
bkeryan
reviewed
Apr 24, 2024
|
@bkeryan can you take a look at this again when you get a chance? |
bkeryan
requested changes
May 2, 2024
bkeryan
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Rather than store a duplicate copy of .proto files in this repo, which tended to get out-of-date, reference the ni-apis repo as a third_party submodule.
This is also a good time to do this since ni-apis is recently made public and it's a precursor to supporting the new Waveform data type in Python.
Keeping the session.proto file in this repo since we have to compile with this one. It matches nimi-python and nidaqmx-python.
Why should this Pull Request be merged?
Keeps us up-to-date with the latest, single-sourced copy of .proto files.
What testing has been done?
Relying on existing automated tests.