Rename package to ni_measurement_plugin_sdk_service #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixonjoel
requested review from
csjall,
bkeryan,
nstokes-nati and
mshafer-NI
as code owners
bkeryan
reviewed
Jun 14, 2024
bkeryan
approved these changes
Jun 14, 2024
dixonjoel
force-pushed
the
users/jdixon/rename-service-package
branch
from
c3a01e2
to
7e481c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Rename the package to ni_measurement_plugin_sdk_service. Generator will subsequently be renamed to ni_measurement_plugin_sdk_generator. This is for consistency with LabVIEW where the top-level package will be ni-measurement-plugin-sdk. We don't have a top-level package in Python (yet) but this name will be reserved for that top-level package.
See #742 for comparison.
Why should this Pull Request be merged?
PO requested this renaming for consistency.
What testing has been done?
Ran pytest locally.