Rename sequences to append _example #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelpireNI
approved these changes
Jul 1, 2024
dixonjoel
added a commit
that referenced
this pull request
Jul 9, 2024
1 task
dixonjoel
added a commit
that referenced
this pull request
Jul 10, 2024
Rename sequences to append _example (#776)
dixonjoel
added a commit
that referenced
this pull request
Jul 11, 2024
* chore(deps): lock file maintenance * Rename sequences to append _example (#776) * chore(deps): update dependency tox to v4.16.0 (#777) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): lock file maintenance * fix(deps): update dependency nidaqmx to v1 (#779) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency tomlkit to v0.13.0 (#783) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Create a top-level ni-measurement-plugin-sdk meta package (#781) * First pass at a top-level package * Build and publish the SDK package * Lint and fix some dependencies. Delete foo.py. Remove click and mako * Reorganize the package hierarchy and pyproject.toml files * Fix the docs configuration path * Updated working directories * Update working directory for nims * Make a copy of color stubs * Fix lint errors * Working directory for docs * Move scripts into service * Working directory for docs build * Move _docs_source into service * Fix autoapi dir * Fix docs directory * Update proto path * Update working directory for service * Move README into sdk folder * Update working directory for system tests * Update SDK package version from tag during publish * Fix copying of .env.simulation with working directory * Add README to service so poetry install works * Fix tox working directory * Fix test_results path * Fix typo * Fix install_examples script * Clean out docs/ directory after building * Fix caching keys * Use rm -rf docs * Fix readthedocs configuration path * Update CNAME for readthedocs * Update caching keys and locations * Update poetry version for readthedocs * fix(deps): update dependency grpcio to v1.65.0 (#785) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fixes #771 . The sequence names conflict with the simple sequencer in InstrumentStudio for its .seq name. This causes weird errors when you use the sequencer with one of our examples.
Why should this Pull Request be merged?
Makes our examples work with the simple sequencer.
What testing has been done?
None. Should not affect any functionality.