Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[releases/2.0] Fix zipping examples during publish #796

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

dixonjoel
Copy link
Collaborator

What does this Pull Request accomplish?

Publish of the last pre-release failed because of a missing 'dist' directory.

Why should this Pull Request be merged?

Ensure publish and prerelease are complete.

What testing has been done?

None

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your change on top of main.

@dixonjoel dixonjoel changed the base branch from main to releases/2.0 July 14, 2024 18:53
@dixonjoel
Copy link
Collaborator Author

Please rebase your change on top of main.

@bkeryan Sorry I targeted main instead of releases/2.0. I've updated the target branch, please take another look.

@dixonjoel dixonjoel requested a review from bkeryan July 14, 2024 18:54
@dixonjoel dixonjoel closed this Jul 14, 2024
@dixonjoel dixonjoel reopened this Jul 14, 2024
@dixonjoel dixonjoel changed the title Fix zipping examples during publish [releases/2.0] Fix zipping examples during publish Jul 14, 2024
Copy link

Test Results

    30 files  +   20      30 suites  +20   51m 10s ⏱️ + 18m 48s
   653 tests ±    0     653 ✅ ±    0      0 💤 ±    0  0 ❌ ±0 
16 210 runs  +9 820  15 150 ✅ +8 760  1 060 💤 +1 060  0 ❌ ±0 

Results for commit f97cdc9. ± Comparison against base commit 57ae79e.

@dixonjoel dixonjoel merged commit 391ebaf into releases/2.0 Jul 15, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/releases-2.0-fix-archive-zip branch July 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants