Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify mypy invocation by specifying files to check #816

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Jul 30, 2024

What does this Pull Request accomplish?

generator, service:

  • Configure mypy's files and exclude settings in pyproject.toml.

generator:

  • Add a missing __init__.py to prevent error: Source file found twice under different module names: "template" and "ni_measurement_plugin_sdk_generator.template"
  • Add missing type hints to tests.

GitHub:

  • Change workflows to use poetry run mypy without specifying a package or file path.

Why should this Pull Request be merged?

Make it easier to run mypy by moving configuration from the command line to the pyproject.toml.

What testing has been done?

Ran poetry run mypy in both directories.

Copy link

github-actions bot commented Jul 30, 2024

Test Results

    30 files  ±0      30 suites  ±0   41m 15s ⏱️ + 2m 40s
   632 tests ±0     632 ✅ ±0      0 💤 ±0  0 ❌ ±0 
15 580 runs  ±0  14 510 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 7ba9c47. ± Comparison against base commit 8a8495c.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan force-pushed the users/bkeryan/simplify-mypy-invocation branch from a69cad1 to 7ba9c47 Compare July 31, 2024 16:03
@dixonjoel dixonjoel merged commit 78079ce into main Jul 31, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/bkeryan/simplify-mypy-invocation branch July 31, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants