Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/tests: Fix psutil deprecation warning #817

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Jul 30, 2024

What does this Pull Request accomplish?

Update test_security.py to call Process.net_connections() instead of Process.connections().

Update min version of psutil.

Why should this Pull Request be merged?

Fix this deprecation warning:

tests/acceptance/test_security.py::test___loopback_measurement___listening_on_loopback_interface
  D:\dev\measurement-plugin-python\packages\service\tests\acceptance\test_security.py:19: DeprecationWarning: connections() is deprecated and will be removed; use net_connections() instead
    for conn in psutil.Process().connections()

What testing has been done?

Ran updated test.

Copy link

github-actions bot commented Jul 30, 2024

Test Results

    30 files  ±0      30 suites  ±0   40m 51s ⏱️ - 1m 56s
   632 tests ±0     632 ✅ ±0      0 💤 ±0  0 ❌ ±0 
15 580 runs  ±0  14 510 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 975a221. ± Comparison against base commit 7a3f848.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan force-pushed the users/bkeryan/psutil-deprecation-warning branch from 6e4ecf5 to 975a221 Compare July 31, 2024 18:19
@bkeryan bkeryan merged commit 7d1a5fe into main Jul 31, 2024
17 checks passed
@bkeryan bkeryan deleted the users/bkeryan/psutil-deprecation-warning branch July 31, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants