Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive mode for client generation #883

Merged
merged 43 commits into from
Sep 17, 2024

Conversation

MounikaBattu17
Copy link
Contributor

@MounikaBattu17 MounikaBattu17 commented Sep 12, 2024

What does this Pull Request accomplish?

Facilities the measurement client generation in interactive mode.

Why should this Pull Request be merged?

This implementation facilitates the users to generate python client in interactive mode.

  • With click-option-group, made
    • --all, --interactive, --measurement_service_class as individual modes and mutually exclusive to each other.
    • --module_name, --class_name, directory_out as optional parameters.
  • Now the command can be used as follows:
    • ni-measurement-plugin-client-generator -a -> creates clients for all registered measurements.
      Optional parameters -m, -c will be ignored if specified.

    • ni-measurement-plugin-client-generator -i -> creates clients for any registered measurements interactively.
      Optional parameters -m, -c, -o will be ignored if specified.

    • ni-measurement-plugin-client-generator -s "ni.examples.SampleMeasurement_Python" -> creates clients for given measurement.
      Optional parameters -m, -c, -o are recommended in this mode.

      • To specify multiple clients for this mode use this
        ni-measurement-plugin-client-generator -s "ni.examples.SampleMeasurement_Python" -s "ni.examples.GameOfLife_Python"
  • The version for click-opt-group is >=0.5.61.
  • Refactored create_client method in __init.py__.
  • Existing test updates and new tests for interactive mode will be covered as a part of another PR.

What testing has been done?

Verified commands manually.
Automated tests yet to be added.

@MounikaBattu17
Copy link
Contributor Author

MounikaBattu17 commented Sep 12, 2024

Here is a small gif on the client creation through interactive workflow
Client-InteractiveMode

Copy link

github-actions bot commented Sep 12, 2024

Test Results

    30 files  ±0      30 suites  ±0   45m 45s ⏱️ + 7m 15s
   651 tests ±0     651 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 130 runs  ±0  15 060 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit edb8f91. ± Comparison against base commit 7d4d8c8.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants