-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive mode for client generation #883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounikaBattu17
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
September 12, 2024 10:34
MounikaBattu17
requested review from
jayaseelan-james and
Avinash2Suresh
and removed request for
Avinash2Suresh
September 12, 2024 11:03
bkeryan
requested changes
Sep 12, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__main__.py
Outdated
Show resolved
Hide resolved
mshafer-NI
reviewed
Sep 13, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
Sep 13, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
Sep 13, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Sep 16, 2024
bkeryan
reviewed
Sep 16, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
jayaseelan-james
approved these changes
Sep 17, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Show resolved
Hide resolved
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Facilities the measurement client generation in interactive mode.
Why should this Pull Request be merged?
This implementation facilitates the users to generate python client in interactive mode.
--all
,--interactive
,--measurement_service_class
as individual modes and mutually exclusive to each other.--module_name
,--class_name
,directory_out
as optional parameters.ni-measurement-plugin-client-generator -a
-> creates clients for all registered measurements.Optional parameters
-m
,-c
will be ignored if specified.ni-measurement-plugin-client-generator -i
-> creates clients for any registered measurements interactively.Optional parameters
-m
,-c
,-o
will be ignored if specified.ni-measurement-plugin-client-generator -s "ni.examples.SampleMeasurement_Python"
-> creates clients for given measurement.Optional parameters
-m
,-c
,-o
are recommended in this mode.ni-measurement-plugin-client-generator -s "ni.examples.SampleMeasurement_Python" -s "ni.examples.GameOfLife_Python"
>=0.5.61
.create_client
method in__init.py__
.What testing has been done?
Verified commands manually.
Automated tests yet to be added.