Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[releases/2.1] Cherry-pick: Add test case to check mypy error in generated client and fix existing mypy errors #929

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[releases/2.1] Cherry-pick: Add test case to check mypy error in generated client and fix existing mypy errors #929

merged 2 commits into from
Sep 24, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

Cherry-pick the change in PR #914

@Jotheeswaran-Nandagopal
Add test case to check mypy error in generated client and fix existin…
87c66a1 
…g mypy errors (#914)

* fix: add test case to run mypy in the generated client

(cherry picked from commit 58ced1a)
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Test Results

    40 files  ± 0      40 suites  ±0   51m 53s ⏱️ -38s
   693 tests + 1     693 ✅ + 1      0 💤 ±0  0 ❌ ±0 
16 830 runs  +10  15 760 ✅ +10  1 070 💤 ±0  0 ❌ ±0 

Results for commit d03922e. ± Comparison against base commit dfab957.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan merged commit 16879f6 into releases/2.1 Sep 24, 2024
17 checks passed
@bkeryan bkeryan deleted the users/jothees/cherry-pick-fix-mypy-errors branch September 24, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel dixonjoel approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@bkeryan bkeryan Awaiting requested review from bkeryan bkeryan is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jotheeswaran-Nandagopal @dixonjoel @bkeryan