Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daqmx 21.5 support #136

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Add daqmx 21.5 support #136

merged 2 commits into from
Feb 1, 2022

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented Jan 31, 2022

Overview

This adds support for DAQmx 21.5 API elements to nidaqmx-python along with additional improvements.

  • No more empty docstrings on constants.
  • Fix C API function mapping for attributes - dozens were incorrect.
  • Remove some internal-only enumerations that were unused.
  • (compat breaker) Fix two egregious naming issues when translating the API to SNAKE_CASE. M_HZ is now MHZ (megahertz) and <word>m_VOLTS is now MILLIVOLTS.
  • (compat breaker) Fix various constant names that didn't make any sense.
  • Add a header to all auto-generated files indicating that they should not be edited by hand.
  • Closes __future__ imports are now all mandatory in the minimum supported python version #132

Testing

All tests pass:

  py37: commands succeeded
  py38: commands succeeded
  py39: commands succeeded
  py310: commands succeeded
  congratulations :)

@zhindes
Copy link
Collaborator Author

zhindes commented Jan 31, 2022

Need to update CONTRIBUTING.md

@zhindes
Copy link
Collaborator Author

zhindes commented Jan 31, 2022

Need to update CONTRIBUTING.md

Done!

@zhindes zhindes merged commit 8107d15 into ni:master Feb 1, 2022
@zhindes zhindes mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__future__ imports are now all mandatory in the minimum supported python version
2 participants