Update AI Bridge Default Argument Values #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for DAQmx calibration info properties * updated cal functions to property and docstrings * fixed merged conflicts * removed wanted cal attributes from exclude list * removed extra new line * rerun codegen and updated device file * added test cases * fixed python coding style violation * fixed python coding style violation part 2 * addressed reviewer's comments * fixed test case name and import order * added try-finally in test case * marked grpc_xfail for failed test case * fixed conflicts and update test cases * fixed linter error
|
Encountered some codegen whitespace issue previously, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR aims to address the issue brought up in #482
forward_coeffs,reverse_coeffs,electrical_valsandphysical_valsare set toNoneadd_ai_force_bridge_polynomial_chanadd_ai_force_bridge_table_chanadd_ai_pressure_bridge_polynomial_chanadd_ai_pressure_bridge_table_chanadd_ai_torque_bridge_polynomial_chanadd_ai_torque_bridge_table_chanWhy should this Pull Request be merged?
This PR will address issue #482 and changes the default values of the respective parameter for the impacted functions, following the default set in LabVIEW.
What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.