Focusing the editor before clicking from the options

ni · Oct 3, 2024 · bac5193 · bac5193
1 parent 205e13d
commit bac5193
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/nimble-components/src/rich-text/editor/testing/rich-text-editor.pageobject.ts b/packages/nimble-components/src/rich-text/editor/testing/rich-text-editor.pageobject.ts
@@ -439,6 +439,10 @@ export class RichTextEditorPageObject {
     }
 
     public async clickMentionListboxOption(index: number): Promise<void> {
+        if (this.isMentionListboxOpened()) {
+            this.richTextEditorElement.tiptapEditor.commands.focus();
+            await waitForUpdatesAsync();
+        }
         const listOption = this.getAllListItemsInMentionBox()[index];
         listOption?.click();
         await waitForUpdatesAsync();

diff --git a/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts b/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts
@@ -1566,9 +1566,10 @@ describe('RichTextEditorMentionListbox', () => {
                         'username1',
                         'username2'
                     ]);
-                    // expect(pageObject.isMentionListboxOpened()).toBeTrue();
+                    expect(pageObject.isMentionListboxOpened()).toBeTrue();
 
-                    await pageObject.clickMentionListboxOption(0);
+                    // await pageObject.clickMentionListboxOption(0);
+                    await pageObject.sliceEditorContent(0, 2);
 
                     await appendTestMentionConfiguration(element, [
                         { key: 'test:1', displayName: 'testname1' },
@@ -1581,7 +1582,7 @@ describe('RichTextEditorMentionListbox', () => {
                         'testname1',
                         'testname2'
                     ]);
-                    // expect(pageObject.isMentionListboxOpened()).toBeTrue();
+                    expect(pageObject.isMentionListboxOpened()).toBeTrue();
                 }
             );
         }

diff --git a/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts b/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts
@@ -360,7 +360,9 @@ Plain text 3`);
                 await appendUserMentionConfiguration(element, [
                     { key: 'user:1', displayName: 'username1' }
                 ]);
+
                 await commitFirstMentionBoxOptionIntoEditor('@');
+
                 expect(element.getMarkdown()).toEqual('<user:1> ');
             });
         }