Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate to rebase PRs less frequently #1640

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented Nov 1, 2023

Pull Request

🤨 Rationale

Once Renovate has created PRs it currently updates them any time something else changes in the repo. This is annoying because it uses lots of build resources and makes it hard to track down a completed build for the PR, for example to inspect Storybook.

In a PR discussion we decided to switch to manually triggering the rebase before merging the PR.

👩‍💻 Implementation

  1. Update renovate.json to rebaseWhen: conflicts. This seems more helpful than never but hopefully less noisy than auto.
  2. Update CONTRIBUTING to mention that owners may need to manually trigger the rebase

🧪 Testing

We'll see if it works the next time Renovate creates PRs.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI mentioned this pull request Nov 1, 2023
1 task
@rajsite rajsite marked this pull request as ready for review November 1, 2023 17:31
@rajsite rajsite enabled auto-merge (squash) November 1, 2023 17:31
@rajsite rajsite merged commit 2656bad into main Nov 1, 2023
10 checks passed
@rajsite rajsite deleted the renovate-rebase branch November 1, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants