Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fast-foundation dependency #1642

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Update fast-foundation dependency #1642

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f874ae
Update fast-foundation dependency
mollykreis Nov 1, 2023
a467c0d
Change files
mollykreis Nov 1, 2023
e74c0b8
Fix rich text editor tests
mollykreis Nov 2, 2023
dd36e1b
Merge branch 'main' into update-fast
mollykreis Nov 2, 2023
f93a7ea
Merge branch 'main' into update-fast
mollykreis Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-0646d932-fb49-424e-83d9-9b6640713cb9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update fast-foundation dependency",
"packageName": "@ni/nimble-components",
"email": "20542556+mollykreis@users.noreply.github.com",
"dependentChangeType": "patch"
}
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nimble-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"dependencies": {
"@microsoft/fast-colors": "^5.3.1",
"@microsoft/fast-element": "^1.12.0",
"@microsoft/fast-foundation": "^2.49.2",
"@microsoft/fast-foundation": "^2.49.3",
"@microsoft/fast-web-utilities": "^6.0.0",
"@ni/nimble-tokens": "^6.7.0",
"@tanstack/table-core": "^8.10.7",
Expand Down
2 changes: 2 additions & 0 deletions packages/nimble-components/src/rich-text/editor/testing/rich-text-editor.pageobject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ export class RichTextEditorPageObject {

public async clickFooterButton(button: ToolbarButton): Promise<void> {
const toggleButton = this.getFormattingButton(button);
const event = new Event('mousedown', { bubbles: true });
toggleButton!.dispatchEvent(event);
toggleButton!.click();
mollykreis marked this conversation as resolved.
Show resolved Hide resolved
await waitForUpdatesAsync();
}
Expand Down
Loading