Manually update @ni/eslint-config-angular dependency to latest #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
#1795 had a build issue because of Angular version mismatches. We want to fix that upgrade to unblock future Renovate dependency updates.
👩💻 Implementation
Ran
npm i -D -w @ni-private/angular-workspace @ni/eslint-config-angular@latest.The problem is that Renovate was only doing minor/patch updates for this dependency but the latest minor update (
5.1.1) introduces this build issue because it tried to claim support for multiple Angular versions. The latest major update (6.0.0) fixes it.🧪 Testing
Relying on pipeline. The latest version doesn't contain any functional changes, it was just published to try to deal with Angular version issues.
✅ Checklist