-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file_share param into workflows #297
Conversation
2907b31
to
4c75654
Compare
@@ -23,6 +23,7 @@ def test_brt(mock_nfs_mount): | |||
TargetNumberOfBeads=20, | |||
LocalAlignments=0, | |||
THICKNESS=30, | |||
file_share="test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new api call will have an added file_share
string parameter. The possible strings are defined in FileShareEnum
.
from enum import Enum | ||
|
||
|
||
class FileShareEnum(Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShareNames are a type of Enum.
4c75654
to
0d06b59
Compare
6a5b400
to
56ca7b4
Compare
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)em_workflows/utils/utils.py
em_workflows/czi/flow.py
em_workflows/dm_conversion/flow.py
em_workflows/enums.py
em_workflows/lrg_2d_rgb/flow.py
em_workflows/config.py
em_workflows/file_path.py
|
56ca7b4
to
16870e7
Compare
0d987f0
to
5928185
Compare
Addresses
file_share
to workflows #295Changes
env
share_name
argument (previously not required)proj_dir
andassets_dir
requiresshare_name
argument (previously relied on env)This PR doesn't introduce any:
print
statementsos.environ['user']
)This PR contains valid: