Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bf2raw command to be central/common function #323

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

annshress
Copy link
Collaborator

@annshress annshress commented Sep 20, 2023

Addresses #316

Changes

  • Move bioformats2raw command in neuroglancer.py (non-task, so it can be mocked easily)
  • Updated pytest github workflow so that .env file exists
  • Breaking changes: "Nothing"❗️

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

@annshress annshress force-pushed the feature/refactor_bf2raw branch 3 times, most recently from ee33ddf to e476747 Compare September 21, 2023 21:35
@niaid niaid deleted a comment from github-actions bot Sep 21, 2023
@annshress annshress force-pushed the feature/refactor_bf2raw branch 2 times, most recently from eba84da to d1e2b1e Compare September 22, 2023 14:12
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Coverage report

The coverage rate went from 26.89% to 64.77% ⬆️
The branch rate is 47%.

24.13% of new lines are covered.

Diff Coverage details (click to unfold)

em_workflows/constants.py

100% of new lines are covered (100% of the complete file).

em_workflows/czi/constants.py

100% of new lines are covered (100% of the complete file).

em_workflows/czi/flow.py

33.33% of new lines are covered (39.79% of the complete file).
Missing lines: 82, 83

em_workflows/utils/neuroglancer.py

20% of new lines are covered (19.14% of the complete file).
Missing lines: 10, 11, 12, 34, 35, 51, 52, 53, 54, 55, 56, 63, 64, 65, 67, 68, 70, 74, 75, 77

@annshress annshress changed the title WIP Refactor bf2raw command to be central/common function Sep 22, 2023
@annshress annshress marked this pull request as ready for review September 25, 2023 13:32
@philipmac philipmac merged commit eb3a36b into main Sep 25, 2023
2 checks passed
@philipmac philipmac deleted the feature/refactor_bf2raw branch September 25, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants