Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing --scale-format-string from bioformats command #331

Merged
merged 1 commit into from
Oct 3, 2023
Merged

removing --scale-format-string from bioformats command #331

merged 1 commit into from
Oct 3, 2023

Conversation

philipmac
Copy link
Member

@philipmac philipmac commented Oct 3, 2023 •
edited
Loading

Addresses #330

Changes

  • removes --scale-format-string "%2$d" from bioformats2raw in utils.ng

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Coverage report

The coverage rate went from 64.77% to 64.77% ➡️
The branch rate is 47%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@annshress annshress merged commit a6a5fa6 into main Oct 3, 2023
2 checks passed
@annshress annshress deleted the rm_scale_format_string branch October 3, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annshress annshress annshress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipmac @annshress