Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for bad .zarr file with missing OME xml #75

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

annshress
Copy link
Contributor

No description provided.

@blowekamp
Copy link
Collaborator

We should be able to procedurally modify an existing ZARR into a temporary directory as a pytest fixture instead of adding more data to the repo.

@annshress annshress closed this Sep 5, 2023
@annshress annshress reopened this Sep 5, 2023
@annshress annshress marked this pull request as draft September 5, 2023 12:32
@annshress annshress marked this pull request as ready for review September 5, 2023 19:48
Copy link
Collaborator

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple minor changes.

pytools/HedwigZarrImage.py Outdated Show resolved Hide resolved
test/test_HedwigZarrImage.py Outdated Show resolved Hide resolved
@blowekamp blowekamp merged commit df0ae6d into niaid:master Sep 6, 2023
7 checks passed
@annshress annshress deleted the test_missing_ome branch September 6, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants