Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add czi tests #78

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Add czi tests #78

merged 2 commits into from
Sep 6, 2023

Conversation

annshress
Copy link
Contributor

  • Adds scene names for missing scene names
  • Adds tests for .czi data file

blowekamp
blowekamp requested changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests look super nice! Great use of monkey patch to test those error cases.

A couple minor suggestions.

pytools/utils/OMEInfo.py Outdated Show resolved Hide resolved
test/test_HedwigZarrImage.py Show resolved Hide resolved
@blowekamp blowekamp self-requested a review September 6, 2023 19:44
@blowekamp blowekamp merged commit 8be5b67 into niaid:master Sep 6, 2023
7 checks passed
@annshress annshress deleted the feature/add_czi_tests branch September 6, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowekamp blowekamp blowekamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annshress @blowekamp