Replace find with filter (#154)

nice-digital · Nov 25, 2021 · e10d9fd · e10d9fd
1 parent fd8d808
commit e10d9fd
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 11 deletions.
diff --git a/src/Header/Nav/Dropdown/Components/AboutUs.jsx b/src/Header/Nav/Dropdown/Components/AboutUs.jsx
@@ -7,9 +7,9 @@ import services from "../../../../services.json";
 import classnames from "classnames";
 
 export function AboutUs() {
-	const baseUrl = services.external.find(
+	const baseUrl = services.external.filter(
 		(service) => service.id == "about"
-	).href;
+	)[0].href;
 
 	const rootUrl = services.rootUrl;
 

diff --git a/src/Header/Nav/Dropdown/Components/BNF.jsx b/src/Header/Nav/Dropdown/Components/BNF.jsx
@@ -6,7 +6,8 @@ import reset from "./../Reset.module.scss";
 import services from "../../../../services.json";
 
 export function BNF() {
-	const baseUrl = services.external.find((service) => service.id == "bnf").href;
+	const baseUrl = services.external.filter((service) => service.id == "bnf")[0]
+		.href;
 
 	const drugsAtoZurl = baseUrl + "/drug/#";
 

diff --git a/src/Header/Nav/Dropdown/Components/BNFc.jsx b/src/Header/Nav/Dropdown/Components/BNFc.jsx
@@ -6,9 +6,8 @@ import reset from "./../Reset.module.scss";
 import services from "../../../../services.json";
 
 export function BNFc() {
-	const baseUrl = services.external.find(
-		(service) => service.id == "bnfc"
-	).href;
+	const baseUrl = services.external.filter((service) => service.id == "bnfc")[0]
+		.href;
 
 	const drugsAtoZurl = baseUrl + "/drug/#";
 

diff --git a/src/Header/Nav/Dropdown/Components/CKS.jsx b/src/Header/Nav/Dropdown/Components/CKS.jsx
@@ -6,7 +6,8 @@ import reset from "./../Reset.module.scss";
 import services from "../../../../services.json";
 
 export function CKS() {
-	const baseUrl = services.external.find((service) => service.id == "cks").href;
+	const baseUrl = services.external.filter((service) => service.id == "cks")[0]
+		.href;
 
 	const topicsAtoZurl = baseUrl + "/topics/#";
 

diff --git a/src/Header/Nav/Dropdown/Components/Guidance.jsx b/src/Header/Nav/Dropdown/Components/Guidance.jsx
@@ -6,9 +6,9 @@ import reset from "./../Reset.module.scss";
 import services from "../../../../services.json";
 
 export function Guidance() {
-	const baseUrl = services.external.find(
+	const baseUrl = services.external.filter(
 		(service) => service.id == "guidance"
-	).href;
+	)[0].href;
 
 	return (
 		<section aria-label="NICE Guidance - dropdown navigation">

diff --git a/src/Header/Nav/Dropdown/Components/LifeSciences.jsx b/src/Header/Nav/Dropdown/Components/LifeSciences.jsx
@@ -5,9 +5,9 @@ import services from "../../../../services.json";
 import reset from "./../Reset.module.scss";
 
 export function LifeSciences() {
-	const baseUrl = services.external.find(
+	const baseUrl = services.external.filter(
 		(service) => service.id == "life-sciences"
-	).href;
+	)[0].href;
 
 	return (
 		<section aria-label="Life Sciences - dropdown navigation">