-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up the Nix interop #209
base: main
Are you sure you want to change the base?
Conversation
c4b6262
to
51308f0
Compare
e444d37
to
26beeda
Compare
51308f0
to
d39a3fd
Compare
26beeda
to
43dd787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an importNcl
left somewhere in lib/lib.nix
within a comment; a search and replace might get rid of those.
Otherwise, I know it's provided as it is, but maybe a bit more documentation on what importNickel
is doing so that non-organist users can make something out of it could be nice. But doesn't have to be in this PR, even if it can.
2d0100f
to
12ed9aa
Compare
Indeed, a quick grep found a few extras in the documentation, thanks.
That's fair. I've added a quick blurb to the function. I don't think it deserves much right now (it's still a bit coupled with Organist, so not producion-ready as an independent thing). |
43dd787
to
a32698b
Compare
Separate the bit about calling Nickel (`importNickel`), and the one really about Organist (`importOrganist`).
12ed9aa
to
a2042c5
Compare
Separate the bit about calling Nickel (
importNickel
), and the one really about Organist (importOrganist
).Doesn't change anything semantically, but
importNickel
function that just calls Nickel and imports back the result without the Organist magicDepends on #203