Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up the Nix interop #209

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Split up the Nix interop #209

wants to merge 3 commits into from

Conversation

thufschmitt
Copy link
Member

@thufschmitt thufschmitt commented Jun 17, 2024

Separate the bit about calling Nickel (importNickel), and the one really about Organist (importOrganist).

Doesn't change anything semantically, but

  1. Makes the flow (hopefully) clearer
  2. Allow exporting a lower-level importNickel function that just calls Nickel and imports back the result without the Organist magic

Depends on #203

Copy link
Contributor

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an importNcl left somewhere in lib/lib.nix within a comment; a search and replace might get rid of those.

Otherwise, I know it's provided as it is, but maybe a bit more documentation on what importNickel is doing so that non-organist users can make something out of it could be nice. But doesn't have to be in this PR, even if it can.

@thufschmitt
Copy link
Member Author

I think there's an importNcl left somewhere in lib/lib.nix within a comment; a search and replace might get rid of those.

Indeed, a quick grep found a few extras in the documentation, thanks.

Otherwise, I know it's provided as it is, but maybe a bit more documentation on what importNickel is doing so that non-organist users can make something out of it could be nice. But doesn't have to be in this PR, even if it can.

That's fair. I've added a quick blurb to the function. I don't think it deserves much right now (it's still a bit coupled with Organist, so not producion-ready as an independent thing).

Théophane Hufschmitt added 3 commits June 21, 2024 06:47
Separate the bit about calling Nickel (`importNickel`), and the one really about
Organist (`importOrganist`).
@thufschmitt thufschmitt changed the base branch from transparent-regen to main June 21, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants