Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to serde (Rebase of #52) #55

Closed
wants to merge 9 commits into from
Closed

Switch to serde (Rebase of #52) #55

wants to merge 9 commits into from

Conversation

Ryman
Copy link
Member

@Ryman Ryman commented Oct 31, 2017

This is a rebase of #52.

erickt and others added 7 commits October 31, 2017 19:07
@erickt @Ryman
Don't import the Error variants into the namespace
4d73c4e
@erickt @Ryman
Extract out most of the tests into tests/
0f9a639 
The only tests not extracted are compiler and parser,
which depend on the private `Token` type.
@erickt @Ryman
Switch over to using serde 1.x
8b52ace
@erickt @Ryman
Stop exporting Data's variants; StrVal->String, VecVal->Vec, split Op…
03fa251 
…tVal

This updates the Data enum to follow the more standard practice of not
exporting enum variants. Furthermore, this also renames a few of the
variants to match a more modern style. So `StrVal` -> `String`,
`VecVal` -> `Vec`, and `OptVal` is converted into a `Null` variant.
@erickt @Ryman
Stop exporting the modules builder, encoder, and parser
71684f2
@erickt @Ryman
Major version bump
a2c712a
@Ryman
Add smoketests for Template::render_to_string()
6168233
@Ryman Ryman mentioned this pull request Oct 31, 2017
Closed
@volks73 volks73 mentioned this pull request Nov 28, 2017
Closed
@Ryman
Copy link
Member Author

Ryman commented Dec 23, 2017

Expecting travis to fail unless budziq/rust-skeptic#71 is merged (fails locally for me). If it's not then we could skip the readme tests for older compiler versions or something as an easy workaround.

@Kerollmops
Copy link

Kerollmops commented Feb 11, 2018 •
edited
Loading

Can't we just remove 1.16.0 from the travis.yml file for a moment ? Accept this PR and work on skeptic after ?

The actual blocking compilation is about a shorthand structure argument feature that is not stable on 1.16.0. Do we really need to be valid for this version ?

@Ryman
Test readme using the doc(include) feature on nightly only for now
f36ca6a 
The old method was failing on recent compilers
@Ryman Ryman force-pushed the erickt-master-serde-rebase branch from 3b3aa31 to f36ca6a Compare February 12, 2018 21:09
@Ryman
Copy link
Member Author

Ryman commented Feb 12, 2018 •
edited
Loading

@Kerollmops Yeah, totally! I just lost track of the PR since noone else commented :(

I've redone the skeptic commit to just test the readme on the nightly compiler for now (can't optionally use skeptic as a build dependency because cargo doesn't support optional build/dev deps)

Let's see what Travis says about this!

@Ryman
Copy link
Member Author

Ryman commented Feb 12, 2018

Messed a little with the history to put the version bump at the end: Merged as b1876ca...bdae578

Published as 0.9.0, sorry it took so long! 🥂

@Ryman Ryman closed this Feb 12, 2018
This was referenced Feb 12, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryman @Kerollmops @erickt