Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when remote is not 'origin' #192

Closed
AckslD opened this issue Mar 15, 2022 · 2 comments · Fixed by #191
Closed

Error when remote is not 'origin' #192

AckslD opened this issue Mar 15, 2022 · 2 comments · Fixed by #191

Comments

@AckslD
Copy link
Contributor

AckslD commented Mar 15, 2022

When the upstream of a branch I get the error:

Error: Git2Rs(Error { code: -3, klass: 4, message: "no reference found for shorthand 'origin/<branch-name>'" })

In this case the upstream is called 'fork' of the given branch.
@AckslD AckslD mentioned this issue Mar 15, 2022
Closed
@nickgerace nickgerace added this to the 4.0.0 milestone Mar 15, 2022
@nickgerace
Copy link
Owner

I'll take a look at this soon. The short reason why this is likely happening: there's some hardcoded logic to look for origin/<branch-name> for the unpushed check if I recall correctly. I've been a bit busy, but will take a look soon.

@nickgerace
Copy link
Owner

I should mention too, I'll try to add your scenario here as an integration test!

@nickgerace nickgerace mentioned this issue Apr 16, 2022
Merged
bors bot added a commit that referenced this issue Apr 16, 2022
@bors @nickgerace
Merge #191
4516907 
191: Fix origin remote and config file lookup errors r=nickgerace a=nickgerace

- Fix error when remote is not "origin" and fallback to alternate remotes if
  "origin" is not found
  - Add failure scenario to core integration test
- Fix error where "gfold.toml" not existing would result in execution
  failure
- Add config file lookup behavior to README
- Remove debug flag in favor of RUST_LOG
  - This also results in the logging module being removed since setting
    the logging should be configured via RUST_LOG
- Add RUST_LOG and RUST_BACKTRACE to README and CLI help troubleshooting
  sections
- Update display flags in README to use `-d`
- Update flag description for color to use "never" instead of "off" as
  one of its options
- Add sequencing debug logs (e.g. "foo has completed")
- Switch back to anyhow for its backtrace feature
- Update to 4.0.0-rc.2

Closes #189 
Closes #190 
Closes #192

Co-authored-by: Nick Gerace <nickagerace@gmail.com>
@bors bors bot closed this as completed in #191 Apr 16, 2022
@nickgerace nickgerace mentioned this issue May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix origin remote and config file lookup errors nickgerace/gfold
2 participants
@AckslD @nickgerace