Use a slice to accumulate errors #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a buffered channel to return errors, use two slices to accumulate all errors, and return other errors before yacc-errors.
nickng
commented
Aug 18, 2022
| case err := <-l.ParseErrors: | ||
| return nil, err | ||
| switch { | ||
| case len(l.Errors) > 0: // Non-yacc errors |
There was a problem hiding this comment.
This should now be more deterministic as this case is checked first (specs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a buffered channel to return errors, use two slices
to accumulate all errors, and return other errors before yacc-errors.
Thanks @its-luca for point this out: #19 (comment)