Would you like to collaborate on this feature in the main notifee repo?

[mikehardy]

Hi there!

I help Invertase maintain the notifee repo, along with react-native-firebase.

We just recently ingested expo config plugins in react-native-firebase (invertase/react-native-firebase#5480) with the help of an interested + motivated community member, and we are curious if you'd like to do something similar in the main Notifee repo so that everyone can get Expo support out of the box from the main repo

Does that sound interesting?

If so, please feel free to propose a PR to notifee implementing the config plugin in packages/react-native, we'd be interested in collaborating and getting it merged

Cheers!

[nicko170]

Hey Mike, I was planning on pushing a PR your way once I had a spare few minutes (and could get the tests to pass), this was just a quick hack of a solution to get it in my project after migrating from expo-notifications to react-native-firebase for that sweet crashlytics support :-) I’ll spend some time on the tests today and try and get a PR your way. The only thing I don’t know is how to include it in your build / release pipeline - unless we just include the src and transpiled build in git (I’ve seen a few repos do this). Your thoughts here would be welcome :-) I’ll have a look at how rnfirebase did it too! Warm Regards, Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Mike Hardy ***@***.***> Sent: Monday, October 11, 2021 4:48:56 AM To: nicko170/with-notifee ***@***.***> Cc: Subscribed ***@***.***> Subject: [nicko170/with-notifee] Would you like to collaborate on this feature in the main notifee repo? (#1) Hi there! I help Invertase maintain the notifee repo, along with react-native-firebase. We just recently ingested expo config plugins in react-native-firebase (invertase/react-native-firebase#5480<invertase/react-native-firebase#5480>) with the help of an interested + motivated community member, and we are curious if you'd like to do something similar in the main Notifee repo so that everyone can get Expo support out of the box from the main repo Does that sound interesting? If so, please feel free to propose a PR to notifee implementing the config plugin in packages/react-native, we'd be interested in collaborating and getting it merged Cheers! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#1>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACIJ2LCUW3UMSU25INDDHMDUGHGYRANCNFSM5FWWMD5Q>.

[mikehardy]

In RNFB, if I am remembering and reading this correctly, the plugin is built during package install (via the prepare package.json hook) so it's then available to npm as npm does it's pack thing before publish

https://github.com/invertase/react-native-firebase/pull/5480/files#diff-9fa008865bef344ab2f931a4ddf20163882b86ee764718adacf098dc19991946R12-R14

Should work? Either way, excited that you're interested. It's open source no pressure or anything, whenever you think it's ready just what you've got and we can get through it. Cheers