Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: improve portability of the ficlone ioctl #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

th1000s
Copy link

@th1000s th1000s commented Sep 19, 2021

Use the request_code_write!() macro copied from the nix crate to
portably generate the request code.

Since the ficlone ioctl takes two file descriptors it can not be created
by one of the nix::ioctl* macros, so avoid the nix dependency.

Use the request_code_write!() macro copied from the nix crate to
portably generate the request code.

Since the ficlone ioctl takes two file descriptors it can not be created
by one of the nix::ioctl* macros, so avoid the nix dependency.
@fogti
Copy link

fogti commented Sep 11, 2022

request_code_write! is exported from nix (at least now), how big would be the disadvantage of pulling in nix without any additional features, maybe besides ioctl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants