This repository has been archived by the owner on Oct 11, 2020. It is now read-only.
Fix list updating inifite loading #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicole-ashley
suggested changes
Oct 16, 2016
| }; | ||
| broadcast: true, | ||
| msg: message | ||
| }; |
There was a problem hiding this comment.
Looks like an unintentional change here?
There was a problem hiding this comment.
This was actually intended, makes more sense IMHO.
|
And sorry for the delay; GitHub notifications are still not being very helpful and alerting me when there is new activity. |
japborst
force-pushed
the
patch-listupdating
branch
from
2d7e68e
to
91afc52
Compare
|
@nikrolls Just updated. I subscribed to watch this repo and receive notifications for all issues and PRs through email, but I believe you can change that in your account settings. |
|
Hmm, maybe I have some settings on my account causing an issue. I'll check it out. |
|
Thanks for the contribution! I'll update the releases tonight and get this out with it. |
nicole-ashley
approved these changes
Oct 16, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the updating of lists seemed to hang and spit out an
handle is invaliderror. For me, this revolved around the broadcast method that seemed to fail in some cases. From trial and error, I found that most cases it fails when a port has nosenderobject attached. This worked in most cases, but not all.Mozilla and MSDN have good docs on messaging, but as it works well in Chrome this seems to be Edge-specific (for which I couldn't find any docs).
Perhaps this is not the best solution, as we don't know the actual cause of the fail... But I'd like to argue to have this implement anyhow, as any weird error shouldn't stop the function from broadcasting the message.
Would fix #18. Both applying a new list selection and visually updating lists by showing the progress seem to work now.