fix compilation after validation result decoupling, add unit testing …

…ci flow
nicorichard · Jul 9, 2024 · 23f0fc1 · 23f0fc1
1 parent 19a4798
commit 23f0fc1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -0,0 +1,12 @@
+name: Unit Test
+on:
+  push:
+
+jobs:
+  test:
+    name: Unit Test
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: unit test package
+        run: swift test
diff --git a/Sources/XCStringsLint/services/Reporter/CommandLineReporter.swift b/Sources/XCStringsLint/services/Reporter/CommandLineReporter.swift
@@ -16,10 +16,10 @@ struct CommandLineReporter: Reporter {
     func report(results: [Validator.Validation]) throws {
         for result in results {
             let message = "xcstringslint failed for key `\(result.key)`: " + result.validations.map { validation in
-                "\(validation.message) (\(type(of: validation.rule).name))"
+                "\(validation.message) (\(validation.name))"
             }.joined(separator: ",")
 
-            if result.validations.map(\.rule.severity).contains(.error) {
+            if result.validations.map(\.severity).contains(.error) {
                 print(message)
             } else {
                 print(message)
@@ -30,7 +30,7 @@ struct CommandLineReporter: Reporter {
             result.validations
         }
 
-        let errors = validations.filter { $0.rule.severity == .error }
+        let errors = validations.filter { $0.severity == .error }
 
         if !errors.isEmpty {
             print("Found \(results.count) total xcstringlint issues in \(results.count) keys, \(errors.count) serious")

diff --git a/Sources/XCStringsLint/services/Reporter/XcodeReporter.swift b/Sources/XCStringsLint/services/Reporter/XcodeReporter.swift
@@ -18,10 +18,10 @@ struct XcodeReporter: Reporter {
     func report(results: [Validator.Validation]) throws {
         for result in results {
             let message = "xcstringslint failed for key `\(result.key)`: " + result.validations.map { validation in
-                "\(validation.message) (\(type(of: validation.rule).name))"
+                "\(validation.message) (\(validation.name))"
             }.joined(separator: ",")
 
-            if result.validations.map(\.rule.severity).contains(.error) {
+            if result.validations.map(\.severity).contains(.error) {
                 print(level: .error, message)
             } else {
                 print(level: .warning, message)
@@ -32,7 +32,7 @@ struct XcodeReporter: Reporter {
             result.validations
         }
 
-        let errors = validations.filter { $0.rule.severity == .error }
+        let errors = validations.filter { $0.severity == .error }
 
         if !errors.isEmpty {
             print(level: .error, "Found \(validations.count) total xcstringlint issues in \(results.count) keys, \(errors.count) serious")