Address pending dual-funding PR comments #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains many (small) changes to address most of the pending comments: - removed feature dependency on anchor outputs - the "zerod_channel_id" created confusion, we instead explicitly detail the open and accept cases - "fail the negotiation" was unclear in interactive-tx - clarified field names in `tx_signatures` - many nits from PR comments Thanks to @morehouse, @ariard and @antonilol for the helpful comments.
antonilol
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
lightning#851 (comment), lightning#851 (comment) and lightning#851 (comment) have been addressed correctly
(did i miss any?)
dunxen
reviewed
Oct 20, 2022
dunxen
approved these changes
Oct 20, 2022
morehouse
suggested changes
Oct 20, 2022
There was a problem hiding this comment.
Resolves:
- https://github.com/lightning/bolts/pull/851/files#r942616721
- https://github.com/lightning/bolts/pull/851/files#r942670934
- https://github.com/lightning/bolts/pull/851/files#r942659587
- https://github.com/lightning/bolts/pull/851/files#r942706545
- https://github.com/lightning/bolts/pull/851/files#r942708055
- https://github.com/lightning/bolts/pull/851/files#r995914511
- https://github.com/lightning/bolts/pull/851/files#r942734915
- https://github.com/lightning/bolts/pull/851/files#r942737449
- https://github.com/lightning/bolts/pull/851/files#r942743799
- https://github.com/lightning/bolts/pull/851/files#r942821495
- https://github.com/lightning/bolts/pull/851/files#r996075935
- https://github.com/lightning/bolts/pull/851/files#r942757949
- https://github.com/lightning/bolts/pull/851/files#r942612070
- https://github.com/lightning/bolts/pull/851/files#r993760043
- https://github.com/lightning/bolts/pull/851/files#r995981535
- https://github.com/lightning/bolts/pull/851/files#r942565571
- https://github.com/lightning/bolts/pull/851/files#r942786939
- https://github.com/lightning/bolts/pull/851/files#r942781774
- https://github.com/lightning/bolts/pull/851/files#r942789866
Changes requested to address:
niftynei
approved these changes
Oct 21, 2022
| @@ -104,7 +108,7 @@ The protocol makes the following assumptions: | |||
| - The `feerate` for the transaction is known. | |||
| - The `dust_limit` for the transaction is known. | |||
| - The `nLocktime` for the transaction is known. | |||
| - The transaction version is 2. | |||
| - The `nVersion` for the transaction is known. | |||
| - otherwise: | ||
| - MUST NOT retransmit `channel_ready`, but MAY send `channel_ready` with | ||
| a different `short_channel_id` `alias` field. | ||
| - upon reconnection: | ||
| - MUST ignore any redundant `channel_ready` it receives. | ||
| - MUST ignore any redundant `tx_signatures` it receives. |
|
These all lgtm. Thanks for doing this clean up work! ACK. |
|
Thanks for the review everyone, @niftynei it looks like that can be merged to your branch, and then we only have the following topics to discuss:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains many (small) changes to address most of the pending comments:
tx_signatures@morehouse, @ariard, @antonilol can you please review those changes and let me know if they correctly fix your pending comments?