Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish keyboard layout #168

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Polish keyboard layout #168

merged 3 commits into from
Jun 13, 2024

Conversation

rmitura
Copy link
Contributor

@rmitura rmitura commented May 4, 2024

added Polish keyboard layout based on language letter frequency as per https://www.sttmedia.com/characterfrequency-polish
with accent characters kept together with base ones.

files added: ./flickboard/app/src/main/java/se/nullable/flickboard/model/layouts/PLMessagEase.kt

I am not really a coder and had no previous exposure to kotlin.

@rmitura rmitura mentioned this pull request May 10, 2024
3 tasks
@nightkr
Copy link
Owner

nightkr commented May 14, 2024

Hey! If this is a layout developed from scratch (rather than derived from an official ME layout) then please give it a distinct name. For example, PLRmitura.

@rmitura
Copy link
Contributor Author

rmitura commented May 15, 2024

Thanks for having a look. Layout is overwhelmingly original ME one with some minor changes.
As per your suggestion named it MessageEasyAlternative1
Regards

@nightkr nightkr mentioned this pull request May 15, 2024
@nightkr
Copy link
Owner

nightkr commented Jun 12, 2024

Sorry about the slow response, but I have a few questions here:

  1. Are both Pl and PlAlt1 needed? What's the difference? Can the naming of alt1 be clarified to describe that difference instead?
  2. The reference to https://www.sttmedia.com/characterfrequency-polish implies that it's based on your research, rather than copying the ME layout? This is hard for me to check myself since I no longer have access to ME.

To clarify, original layouts are encouraged! I'd just like to differentiate the labels between ME layouts and "ME-style" layouts.

@rmitura
Copy link
Contributor Author

rmitura commented Jun 12, 2024

Hi Natalie,
Thanks for getting back to me.
re1 don't think PL and PLalt1 are needed, I just tried to play along after all its your project.
re2 Getting an accent char on most keyboards is achieved by long press of base char. This is what I attempted to do with with my layout variant. Attached screen dump for both for comparison.
Regards,

kb_comparison

nightkr added a commit that referenced this pull request Jun 13, 2024
@nightkr nightkr merged commit 3f4ee26 into nightkr:main Jun 13, 2024
@rmitura rmitura deleted the rename branch June 27, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants