Support Spark 3.4 #754
Merged
Support Spark 3.4 #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I moved the parameter/attribute handling of ExcelOptions into a Trait that is available to all builds. The version specific ExcelOptions just inherit the trait and implement the version specific logic. I kept to the folder logic and did not introduce something like a "below_some_version". So looks good to me. @nightscape , what do you think? As a side note: I think it would simplify things if we just start dropping support for older spark versions (similar to spark versioning policy). What are your thoughts on this? |
nightscape
reviewed
Jul 31, 2023
|
@christianknoepfle looks good overall! |
|
Release build for 0.19.0 is running: https://github.com/crealytics/spark-excel/actions/runs/5732141933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for #730
First trying to make a clean build for a targets and all tests passed. Then rework the folder structure (again)