-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send reason for failed session to browserstack #2357
send reason for failed session to browserstack #2357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't merge this, but it lgtm!
I'm not sure this would be very useful in the case of a big number of failed testcases, also we cannot be sure that the title of the test cases is safe to be sent to browserstack, as in it might contain sensitive information, such as emails and other privacy related data. The only thing we could do here is to provide a mechanism so that users can define their own "reason" exporting function. |
With a big number of failed testcases (per test-suite that is, as they are collected on suite-level), this is not optimal that is true (the title gets truncated after 255 characters). However, right now it only shows "failed" which isn't very helpful (even less if there are a lot of failed tests) and it always involves quite some effort to backtrace the failed test (for every single failed test, without even knowing how many of them failed). Regarding sensitive information in the title of test cases: If the reason-exporting function has access to the failed tests (and thus can extract the titles automatically, if desired) and if it can be declared globally that's fine as well. As it is right now, for a browserstack-test-setup with a multitude of OSes, browsers and browser versions (which is the purpose of browserstack) and more than one test per test-suite, the overhead of identifying the failed tests is too high to make use of nightwatch with the browserstack-reporter. |
Which browserstack-reporter are you referring to? |
Sorry, I meant "transport", not "reporter" |
This issue has been automatically marked as stale because it has not had any recent activity. |
I still think this would be a nice-to-have option. |
Closes #2356
This PR will send the name of the failed tests to Browserstack.