Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send reason for failed session to browserstack #2357

Conversation

codekie
Copy link

@codekie codekie commented Mar 6, 2020

Closes #2356

This PR will send the name of the failed tests to Browserstack.

Copy link

@AshishKapoor AshishKapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MicahLC MicahLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't merge this, but it lgtm!

@beatfactor
Copy link
Member

beatfactor commented May 2, 2020

I'm not sure this would be very useful in the case of a big number of failed testcases, also we cannot be sure that the title of the test cases is safe to be sent to browserstack, as in it might contain sensitive information, such as emails and other privacy related data.

The only thing we could do here is to provide a mechanism so that users can define their own "reason" exporting function.

@codekie
Copy link
Author

codekie commented May 13, 2020

With a big number of failed testcases (per test-suite that is, as they are collected on suite-level), this is not optimal that is true (the title gets truncated after 255 characters). However, right now it only shows "failed" which isn't very helpful (even less if there are a lot of failed tests) and it always involves quite some effort to backtrace the failed test (for every single failed test, without even knowing how many of them failed).

Regarding sensitive information in the title of test cases:
Browserstack saves screenshots and even screen recordings of the test-scenarios, which may contain way more sensitive information than just in the test-title. Everyone who uses Browserstack is aware of that. So, I think, having the test-titles there should not be much of an issue unless someone puts critical information like passwords or environment-variables there.

If the reason-exporting function has access to the failed tests (and thus can extract the titles automatically, if desired) and if it can be declared globally that's fine as well.

As it is right now, for a browserstack-test-setup with a multitude of OSes, browsers and browser versions (which is the purpose of browserstack) and more than one test per test-suite, the overhead of identifying the failed tests is too high to make use of nightwatch with the browserstack-reporter.

@beatfactor
Copy link
Member

Which browserstack-reporter are you referring to?

@codekie
Copy link
Author

codekie commented May 13, 2020

Sorry, I meant "transport", not "reporter"

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had any recent activity.
If possible, please retry using the latest Nightwatch version and update the issue with any relevant details. If no further activity occurs, it will be closed. Thank you for your contribution.

@stale stale bot added the stale label Aug 16, 2020
@MicahLC
Copy link
Contributor

MicahLC commented Aug 18, 2020

I still think this would be a nice-to-have option.

@stale stale bot closed this Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Send names of failed tests to Browserstack
5 participants