Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi file data override yaml #3

Conversation

uramirez8707
Copy link

Description
implement the multi file data override in yaml and update the documentation

Fixes # (issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Copy link

@raphaeldussin raphaeldussin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor changes required, LGTM otherwise

@@ -24,6 +24,13 @@ If it is desired to interpolate the data to a region of the model grid. The foll
- **lat_start:** The starting longitude in the same units as the grid data in the file
- **lon_end:** The ending longitude in the same units as the grid data in the file

If it is desired to use multiple(3) input netcf files instead of 1. The following **optional** keys are available.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netcdf

- **prev_file_name:** The name of the first file in the set
- **next_file_name:** The name of the third file in the set

Note that **file_name** must be the second file in the set. **prev_file_name** and **next_file_name** are required if **is_multi_file** is set to `True`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and/or

I have updated the code so that we can use only prev or next, still needs 2 separators in the old diag_table though

& is_optional=.true.)
call get_value_from_key(file_id, entry_id(i), "next_file_name", data_table(i)%next_file_name, &
& is_optional=.true.)
if (trim(data_table(i)%prev_file_name) .eq. "" .or. trim(data_table(i)%next_file_name) .eq. "") &

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.or. -> .and.

@nikizadehgfdl nikizadehgfdl merged commit e35629e into nikizadehgfdl:raphDussin_multifile_dataoverride Nov 30, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants