Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseDisplayValue doesnt support "-webkit-" styles #1817

Closed
SuperCoolSEBoy opened this issue Apr 24, 2019 · 0 comments · Fixed by #1828
Closed

parseDisplayValue doesnt support "-webkit-" styles #1817

SuperCoolSEBoy opened this issue Apr 24, 2019 · 0 comments · Fixed by #1828
Labels

Comments

@SuperCoolSEBoy
Copy link

Please make sure you are testing with the latest release of html2canvas.
Old versions are not supported and issues reported for them will be closed.

Please follow the general troubleshooting steps first:

  • [yes] You are using the latest version
  • [yes] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:

parseDisplayValue function in src/parsing/display.js doesn't support "-web-kit-*" styles.
I am testing with Microsoft Edge and have an element with display value as "-web-kit-flex". But parseDisplayValue returns Display.None since it's not in the supported list. And later, that element won't be rendered on the canvas since it is "invisible".

it works as expected on other browsers except Edge (even IE11 works). Hope the new chromiun Edge would have this problem solved. But at least for the latest released version, it is broken.

Open it in Edge, you will only see one red square. But in other browsers, you will see 2.
https://jsfiddle.net/7dqL4jf2/

Specifications:

  • html2canvas version tested with: html2canvas 1.0.0-rc.1
  • Browser & version: Microsoft Edge 44.17763.1.0, Microsoft EdgeHTML 18.17763
  • Operating system: Windows 10
@niklasvh niklasvh added the Bug label May 6, 2019
niklasvh added a commit that referenced this issue May 25, 2019
* initial typescript conversion

* test: update overflow+transform ref test

* fix: correctly render pseudo element content

* fix: testrunner build

* fix: karma test urls

* test: update underline tests with <u> elements

* test: update to es6-promise polyfill

* test: remove watch from server

* test: remove flow

* format: update prettier for typescript

* test: update eslint to use typescript parser

* test: update linear gradient reftest

* test: update test runner

* test: update testrunner promise polyfill

* fix: handle display: -webkit-flex correctly (fix #1817)

* fix: correctly render gradients with clip & repeat (fix #1773)

* fix: webkit-gradient function support

* fix: implement radial gradients

* fix: text-decoration rendering

* fix: missing scroll positions for elements

* ci: fix ios 11 tests

* fix: ie logging

* ci: improve device availability logging

* fix: lint errors

* ci: update to ios 12

* fix: check for console availability

* ci: fix build dependency

* test: update text reftests

* fix: window reference for unit tests

* feat: add hsl/hsla color support

* fix: render options

* fix: CSSKeyframesRule cssText Permission Denied on Internet Explorer 11 (#1830)

* fix: option lint

* fix: list type rendering

* test: fix platform import

* fix: ie css parsing for numbers

* ci: add minified build

* fix: form element rendering

* fix: iframe rendering

* fix: re-introduce experimental foreignobject renderer

* fix: text-shadow rendering

* feat: improve logging

* fix: unit test logging

* fix: cleanup resources

* test: update overflow scrolling to work with ie

* build: update build to include typings

* fix: do not parse select element children

* test: fix onclone test to work with older IEs

* test: reduce reftest canvas sizes

* test: remove dynamic setUp from list tests

* test: update linear-gradient tests

* build: remove old source files

* build: update docs dependencies

* build: fix typescript definition path

* ci: include test.js on docs website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants