Revert "Fix underlines, relative to 'bottom' baseline" #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c8d38d.
|
Bummer this isn't merged, yet. Pretty noticeable bug. Had to pull this into the project instead of loading via npm in order to apply the patch. Thanks for providing this fix, @eKoopmans! |
|
Hah well no problem, I did introduce the bug in the first place... |
|
Any idea what is preventing this from going in? Or are we just waiting for author to get back? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0c8d38d.
As described here, the underline fix I submitted was superseded by 38749bc. This fiddle submitted by @FDIM illustrates that it is now causing a problem.
Related: #1292, #1364, #1394.