Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set custom comparator #23

Merged
merged 2 commits into from
Aug 4, 2019

Conversation

dontub
Copy link

@dontub dontub commented Aug 4, 2019

Fixes #22.

@nikolaposa nikolaposa self-assigned this Aug 4, 2019
src/Version.php Outdated Show resolved Hide resolved
src/Version.php Outdated Show resolved Hide resolved
tests/VersionTest.php Outdated Show resolved Hide resolved
@nikolaposa
Copy link
Owner

Overall this looks 👌, just apply those few style corrections. Thanks.

@nikolaposa nikolaposa self-requested a review August 4, 2019 18:37
@nikolaposa nikolaposa merged commit 98392bd into nikolaposa:master Aug 4, 2019
@nikolaposa nikolaposa added this to the 3.2.0 milestone Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing version comparator
2 participants