wanted to make a valuable addition to your project #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksudan
requested changes
Apr 24, 2017
package.json
Outdated
| @@ -20,3 +20,5 @@ | |||
| }, | |||
| "homepage": "https://github.com/niksudan/butt#readme" | |||
| } | |||
|
|
|||
| //I am coder now | |||
There was a problem hiding this comment.
Come on dude, putting a space after // is all the range these days
There was a problem hiding this comment.
Whitespace slows down applications tremendously, I'd like to advice removing it all from the code.
There was a problem hiding this comment.
I'm sorry Dave, I can't do that.
|
Any updates on this? This is quite a heavily requested feature. |
might need optimizing
|
It is done |
niksudan
requested changes
Jan 4, 2018
package.json
Outdated
| @@ -20,3 +20,6 @@ | |||
| }, | |||
| "homepage": "https://github.com/niksudan/butt#readme" | |||
| } | |||
|
|
|||
| // I am coder now | |||
| //EDIT 3-1-2018, Added a space after the comment above on request. Styling is important! | |||
There was a problem hiding this comment.
Can we use YYYY-MM-DD format for timestamps?
niksudan
requested changes
Jan 4, 2018
package.json
Outdated
| @@ -20,6 +20,3 @@ | |||
| }, | |||
| "homepage": "https://github.com/niksudan/butt#readme" | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Let's leave this new line at the end of this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.