Upgrade to 2.1.2

[reuvygroovy]

I just upgraded from 2.0 to 2.1.2, and for some reason e-mail notifications aren't working for me at all. Any idea how I can debug the issue to see what the problem is?

[nilsteampassnet]

I've done a mistake in the commitment of a file.
Can you please open file "includes/libraries/phpmailer/class.phpmailer.php"?
Goto line 162 and change $Port value to 25 instead of 26.

Please came back to me if works or not.

[reuvygroovy]

Still no.

These are the code changes I inputted in the previous version to enable e-mails on changes made:

In \includes\language\english.php:

$txt['email_itemedit_subject'] = "A password has been modified in TeamPass";

In \sources\items.queries.php at line 434 or so after the text:
//Update CACHE table
UpdateCacheTable("update_value", $data_received['id']);

I added:

//Announce by email?

if ( $data_received['annonce'] == 1 ){
    require_once("../includes/libraries/phpmailer/class.phpmailer.php");
    //envoyer email
    $destinataire= explode(';',$data_received['diffusion']);
    foreach($destinataire as $mail_destinataire){
        //envoyer ay destinataire
          $mail = new PHPMailer();
          $mail->SetLanguage("en","../includes/libraries/phpmailer/language");
          $mail->IsSMTP();                                   // send via SMTP
          $mail->Host     = $smtp_server; // SMTP servers
          $mail->SMTPAuth = $smtp_auth;     // turn on SMTP authentication
          $mail->Username = $smtp_auth_username;  // SMTP username
          $mail->Password = $smtp_auth_password; // SMTP password
          $mail->From     = $email_from;
          $mail->FromName = $email_from_name;
        $mail->AddAddress($mail_destinataire);     //Destinataire
          $mail->WordWrap = 80;                              // set word wrap
          $mail->IsHTML(true);                               // send as HTML
          $mail->Subject  =  $txt['email_itemedit_subject'];
          $mail->AltBody     =  $txt['email_altbody_1']." ".mysql_real_escape_string(stripslashes(($_POST['label'])))."                                             ".$txt['email_altbody_2'];
        $corpsDeMail = $txt['email_body_1'].mysql_real_escape_string(stripslashes(($_POST['label']))).$txt['email_body_2'].
          $_SESSION['settings']['cpassman_url']."/index.php?page=items&group=".$_POST['categorie']."&id=".$new_id.$txt['email_body_3'];
          $mail->Body  =  $corpsDeMail;
          $mail->Send();
    }
}

That worked for me before the upgrade, but no longer after. Any way I can debug the mail function to see what the problem is?

Reuvy

-----Original Message-----
From: Nils Laumaillé [mailto:reply@reply.github.com]
Sent: Sunday, January 15, 2012 11:37 AM
To: ראובן סינגר (LREUVEN)
Subject: Re: [TeamPass] Upgrade to 2.1.2 (#17)

I've done a mistake in the commitment of a file.
Can you please open file "includes/libraries/phpmailer/class.phpmailer.php"?
Goto line 162 and change $Port value to 25 instead of 26.

Please came back to me if works or not.

---

Reply to this email directly or view it on GitHub:
#17 (comment)

[chucklebrother]

I had to make this change on my 2.1.2 installation.

After the change I am able to get email password changes. If I create a new password and choose to notify myself I do get an email.

If I choose an existing item, choose to notify myself and then change the password, I don't get an email.

Is this the expected behaviour?

[reuvygroovy]

By me I don't get any notifications at all. I tested on a new item that I created, both before I finished creating, and when I modified the user name. Both times it did not send me a notification.