Uploaded zip files (and others) are corrupted

[skiglades]

Even though the .zip extension is an allowed upload type, any zip files uploaded and then downloaded are corrupted and I receive an error that they are "invalid".

Additional testing through adding allowed file extensions "crt" and "key" also results in corrupted files after downloading them.

[Thu Aug 01 08:40:44.922429 2013] [:error] [pid 920:tid 1044] [client :62451] PHP Warning: readfile(C:/wamp/www//TeamPass-master/files/607af87d56203754d05ed047eb571333): failed to open stream: No such file or directory in C:\wamp\www\TeamPass-master\sources\downloadFile.php on line 25, referer: https:///TeamPass-master/index.php?page=items
[Thu Aug 01 08:40:44.922429 2013] [:error] [pid 920:tid 1044] [client :62451] PHP Stack trace:, referer: https:///TeamPass-master/index.php?page=items
[Thu Aug 01 08:40:44.922429 2013] [:error] [pid 920:tid 1044] [client :62451] PHP 1. {main}() C:\wamp\www\TeamPass-master\sources\downloadFile.php:0, referer: https:///TeamPass-master/index.php?page=items
[Thu Aug 01 08:40:44.922429 2013] [:error] [pid 920:tid 1044] [client :62451] PHP 2. readfile() C:\wamp\www\TeamPass-master\sources\downloadFile.php:25, referer: https:///TeamPass-master/index.php?page=items

Version 2.1.17

[skiglades]

Please let me know if you can re-create this without issues. I also have the ModSecurity firewall installed on the system and am verifying that the firewall isn't having a part in this issue.

[nilsteampassnet]

Can you check with (firebug for example if you are using Fifrefox) if you get an an error after clicking on button "start uploading files"?

[skiglades]

No error after clicking "start uploading files".

Response: "{"jsonrpc" : "2.0", "result" : null, "id" : "id"}"

When downloading the attachment from the TeamPass item, also no error. Except when attempting to open the zip file in Windows, then I receive:

Response:
"Compressed (zipped) Folders Error

Windows cannot open the folder.

The Compressed (zipped) Folder 'C:\filename.zip' is invalid"

[skiglades]

Also, I uploaded a .txt file containing the letter "a". The upload works fine and I'm able to save the item. However, when downloading the attachment, my .txt file contains the following content:

"

( ! ) Warning: readfile(C:///TeamPass-master/files/d6a54b942e0dfb9d0bee2c5e63d69dd4): failed to open stream: No such file or directory in C:\TeamPass-master\sources\downloadFile.php on line 25
Call Stack
#	Time	Memory	Function	Location
1	0.0006	269288	{main}( )	..\downloadFile.php:0
2	0.0011	317424	readfile ( )	..\downloadFile.php:25

"

[skiglades]

[nilsteampassnet]

Thank you for those inputs !

How silly BUG ... in sources\downloadFile.php at line 25, I've included a wrong variable.
Instead of
$_SESSION['settings']['path_to_files_folder'],
it should be
$_SESSION['settings']['path_to_upload_folder']

Should be ok now!

[skiglades]

No problem, thanks for the fix! It works fine now.