Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password change window not closing #51

Closed
syphernl opened this issue Feb 21, 2012 · 7 comments
Closed

Password change window not closing #51

syphernl opened this issue Feb 21, 2012 · 7 comments
Labels
bug

Comments

@syphernl
Copy link

If an admin changes a user password then it does not say its saved or closes the window. it remains open, but does change the password
@nilsteampassnet
Copy link
Owner

What version please?

@syphernl
Copy link
Author

2.1.3

@nilsteampassnet
Copy link
Owner

Can't reproduce.
Is it possible for you to get the error returned (with Firebug for example)?

Can you indicate me what is the password you try to set?

@mmolnar
Copy link

mmolnar commented Feb 28, 2012

I think in sources/main.queries.php on line 128 should be elseif instead of if, at least this has fixed the bug for me.
https://github.com/nilsteampassnet/TeamPass/blob/master/sources/main.queries.php#L128

It's in case "change_pw", in "ADMIN first login" section.

@patricklbs
Copy link

Yes works great same a password who change in first page. Good job if nils aprove it ;)

@nilsteampassnet
Copy link
Owner

Of course you're right, this was a mistake from me.

Thanks ... and added in 2.1.4

@patricklbs
Copy link

Yess Nils,
your work is going well! Excellent. Thank you. Thanks to mmolnar god job.

nilsteampassnet added a commit that referenced this issue Feb 29, 2012
@nilsteampassnet
v2.1.4
92bd44a 
* Corrections: SF237, SF240, SF243 , #29, #25,  #32 , #36 , #37 , #39 , #40
	SF257, SF259, SF239, #41, #40, #51
* Improvements:
	SF232
	SF231:	How to Restrict Admin from Viewing items
	#31: new setting option for dynamic list
	#27: new subfolders only associated to the same roles as the parent folder
	#33: folder management in items page
	Changing SALT key from admin pages
@jescacjim jescacjim mentioned this issue Jul 13, 2018
Open
@funnyavocado funnyavocado mentioned this issue Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@syphernl @nilsteampassnet @patricklbs @mmolnar