Fix #12135 and #12109 #12137
Fix #12135 and #12109 #12137
Conversation
| @@ -132,6 +132,13 @@ else: | |||
| abi: array[56 div sizeof(clong), clong] | |||
| ThreadVarSlot {.importc: "pthread_key_t", | |||
| header: "<sys/types.h>".} = distinct cuint | |||
| elif defined(openbsd) and defined(amd64): | |||
| type | |||
| SysThread* {.importc: "pthread_t", header: "<pthread.h>".} = object | |||
There was a problem hiding this comment.
https://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread.h.html
The pthread_attr_t, pthread_cond_t, pthread_condattr_t, pthread_key_t, pthread_mutex_t, pthread_mutexattr_t, pthread_once_t, pthread_rwlock_t, pthread_rwlockattr_t and pthread_t types are defined as described in <sys/types.h>.
There was a problem hiding this comment.
@Araq Yes, that is true on most systems. However, OpenBSD is a little different. Please see the below links:
pthread.h- see the type definitions from the linked line downwards- A search for
pthread_key_tin the OpenBSD source - note the only definition is inpthread.h sys/types.h- note no references topthreadat all
I made this PR after actually trying the tests on OpenBSD and having them fail due to pthread_key_t being undefined in sys/types.h. This PR is the only way to make the tests pass on OpenBSD (see the error message in the linked issue for a stacktrace and compiler output - #12135)
There was a problem hiding this comment.
Additionally, it seems FreeBSD used to be the same, circa 2005.
There was a problem hiding this comment.
@Araq what is the status of this one?
euantorano
force-pushed
the
fix/12135-and-12109-openbsd-pthread_key_t-and-time_t
branch
from
87556da to
a05cd02
Compare
|
Sorry for the delay. |
euantorano
deleted the
fix/12135-and-12109-openbsd-pthread_key_t-and-time_t
branch
* Fix nim-lang#12135 and fix nim-lang#12109 - fix OpenBSD type defs * Fix Mode definition as in nim-lang#12132
Fixes #12135 and fixes #12109
Note that the
posix_other_constsfile is used (the same goes forposix_macos_amd64) as I can't getdetect.nimto run on OpenBSD.