Locks modules should give a compile error when threads are not enabled. #12231
Conversation
…d. (nim-lang#12231) * Locks modules should give a compile error when threads are not enabled. * fix the compile flags to make the tests pass, or ignore files where necessary. * Fixed when statement to account for doc builds.
…d. (nim-lang#12231) * Locks modules should give a compile error when threads are not enabled. * fix the compile flags to make the tests pass, or ignore files where necessary. * Fixed when statement to account for doc builds.
…d. (nim-lang#12231) * Locks modules should give a compile error when threads are not enabled. * fix the compile flags to make the tests pass, or ignore files where necessary. * Fixed when statement to account for doc builds.
…d. (nim-lang#12231) * Locks modules should give a compile error when threads are not enabled. * fix the compile flags to make the tests pass, or ignore files where necessary. * Fixed when statement to account for doc builds.
|
@rayman22201 what link error did it give? Do you have a minimized example? the PR description is too vague.
|
This was over a year and half ago. I don't remember exactly, and the PR has already long been merged. Why resurrect it now? It was the same as if you compiled a C program that used pthreads and did not add |
Before, it would let you compile, and then throw a linker error with no threads.
This make Locks module work like Threads and Threadpool.
Just a small Quality of Life fix.