Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nimgrep color on posix #7591 #12288

Merged
merged 1 commit into from
Sep 27, 2019
Merged

fix nimgrep color on posix #7591 #12288

merged 1 commit into from
Sep 27, 2019
+12 −4

Conversation

a-mr
Copy link
Contributor

@a-mr a-mr commented Sep 27, 2019

This fixes a couple of color highlighting issues for nimgrep on Linux:

  • bug of option --nocolor being ignored on posix when output is connected to terminal. It's because of the wrong ordering of posix handling and CLI option processing code
  • it's impossible to force it to display in colors. A new option --color:always is added. So nimgrep will follow the convention used by GNU grep, Git, Mercurial, etc. of having options --color [never | always | auto].

@Araq Araq merged commit 5a65243 into nim-lang:devel Sep 27, 2019
@Araq
Copy link
Member

Araq commented Sep 27, 2019

Thank you!

rayman22201 pushed a commit to rayman22201/Nim that referenced this pull request Oct 4, 2019
@a-mr @rayman22201
fix nimgrep color on posix nim-lang#7591 (nim-lang#12288)
c1b6e23
alehander92 pushed a commit to alehander92/Nim that referenced this pull request Oct 23, 2019
@a-mr @alehander92
fix nimgrep color on posix nim-lang#7591 (nim-lang#12288)
3b3d1e2
alehander92 pushed a commit to alehander92/Nim that referenced this pull request Dec 2, 2019
@a-mr @alehander92
fix nimgrep color on posix nim-lang#7591 (nim-lang#12288)
03c53f7
@timotheecour timotheecour mentioned this pull request Apr 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-mr @Araq