Fixes #12187 #12321
Merged
Fixes #12187 #12321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Clyybber I did the same and it breaks too much code which is why I closed the issue as "won't fix". |
Clyybber
added a commit
to Clyybber/nimpy
that referenced
this pull request
Oct 1, 2019
Py_ssize_t should be signed, see https://stackoverflow.com/questions/20987390/cython-why-when-is-it-preferable-to-use-py-ssize-t-for-indexing#20987501 This is a blocker for nim-lang/Nim#12321 which corrects nims csize definition to be uint
This was referenced Oct 1, 2019
Clyybber
added a commit
to Clyybber/hts-nim
that referenced
this pull request
Oct 1, 2019
Clyybber
added a commit
to Clyybber/cligen
that referenced
this pull request
Oct 1, 2019
Clyybber
added a commit
to Clyybber/compactdict
that referenced
this pull request
Oct 1, 2019
brentp
pushed a commit
to brentp/hts-nim
that referenced
this pull request
Oct 1, 2019
yglukhov
pushed a commit
to yglukhov/nimpy
that referenced
this pull request
Oct 2, 2019
Py_ssize_t should be signed, see https://stackoverflow.com/questions/20987390/cython-why-when-is-it-preferable-to-use-py-ssize-t-for-indexing#20987501 This is a blocker for nim-lang/Nim#12321 which corrects nims csize definition to be uint
Clyybber
force-pushed
the
csize_uint_tests
branch
from
1538b58 to
ca8db12
Compare
Since the original repo is now archived / read-only
Merged
alehander92
pushed a commit
to alehander92/Nim
that referenced
this pull request
Dec 2, 2019
* Fixes nim-lang#12187 * Point to fork of compactdict Since the original repo is now archived / read-only
alehander92
pushed a commit
to alehander92/Nim
that referenced
this pull request
Dec 2, 2019
This reverts commit 00c31e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing what fails and what can be fixed..