Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12734 #12784

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Fix #12734 #12784

merged 1 commit into from
Dec 1, 2019

Conversation

demotomohiro
Copy link
Contributor

Unlike Unix, Windows is multiple root file system. I cannot create a relative path from 2 absolute paths with different drive.
When relativeTo cannot create a relative path, it returns absolute path as is.
This fix replace all os.DirSep and os.AltSep in the path returned from relativeTo.

@Araq Araq added the merge_when_passes_CI mergeable once green label Dec 1, 2019
@Araq
Copy link
Member

Araq commented Dec 1, 2019

Unrelated CI failure, merging.

@Araq Araq merged commit 378289c into nim-lang:devel Dec 1, 2019
@demotomohiro demotomohiro deleted the fix-issue-12734 branch December 2, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants