[obsolete] Revert "fix #13182: proc fun(a: varargs[Foo, conv]) now can be overloaded (#13345)
#13379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be overloaded (nim-lang#13345) [backport]" This reverts commit 79ec8c2.
|
@timotheecour I don't, but didn't your original PR first have a different solution to #13182 ? |
|
it did, but 1st solution didn't work; and now looks like 2nd solution doesn't work either... somehow |
|
Let's not merge this, I have a proper fix. |
|
can you also see if your proper fix improves #10975 ? this seems at least somewhat related |
timotheecour
changed the title
proc fun(a: varargs[Foo, conv]) now can be overloaded (#13345)proc fun(a: varargs[Foo, conv]) now can be overloaded (#13345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proc fun(a: varargs[Foo, conv])now can be overloaded #13345very sad, I know ...
maybe someone has a better idea? /cc @Clyybber
note (for whoever wants to revisit #13345)
when compiling nim with --stacktrace:on --debugger:native, the crash in #13378 is inside some cgen code; that means the error should've been detected earlier but wasn't; it's possible that some piece of code didn't check for
result == nilsomewhere down the line afterc.semTryExpr