fix pathSubs for windows: --outdir:@projectpath/foo works cross platform, and without quoting needed
#13407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
timotheecour
commented
Feb 13, 2020
| inc(j) | ||
| if isNumber == 1: | ||
| let idx = if not negative: k-1 else: a.len-k | ||
| else: |
There was a problem hiding this comment.
note to reviewer: you can check the diff manually, but this is pure re-indentation below here
1 task
Araq
reviewed
Apr 24, 2020
| @@ -2623,69 +2623,80 @@ proc findNormalized(x: string, inArray: openArray[string]): int = | |||
| proc invalidFormatString() {.noinline.} = | |||
| raise newException(ValueError, "invalid format string") | |||
|
|
|||
| proc addf*(s: var string, formatstr: string, a: varargs[string, `$`]) {. | |||
| noSideEffect, rtl, extern: "nsuAddf".} = | |||
| proc addfCustom*(s: var string, formatstr: string, subs = {'$'}, a: varargs[string, `$`]) {. | |||
There was a problem hiding this comment.
Just make an addfCustom for the compiler only then...
|
This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before PR
nim c --outdir:'$projectpath'/foo main.nimworks on posix, but not on windows inside exec (inside nims program) or execCmd (inside nim program) or on windows command prompt (only works on windows git bash cmd prompt)nim c --outdir:$projectpath/foo main.nimworks on windows cmd prompt, but not on posix, and not on windows git bash promptlikewise with other path substitutions supported by
pathSubsafter PR
nim c --outdir:@projectpath/foo main.nimworks everywhere (posix and windows, nim or nims or on cmdline), and doesn't require any quotingnote
--docroot:@pkgintroduced in fix #13150nim doc --projectnow works reliably #13223$projectpath)